Vcert-java initial implementation by pegerto · Pull Request #2 · Venafi/vcert-java

pegerto · 2019-03-28T15:22:10Z

No description provided.

Adds authorization functionality for Cloud and Onprem

* adds Read Zone Configuration functionality * adds Wiremock for testing

* Register an user venafi cloud * Add target to gitingnore

* Search cloud certificates * Optimize imports

pegerto · 2019-03-29T18:21:47Z

could you take a look at the current progress, we are progressing on the development, we can add any suggestion base on your input.

* Certificate request pojo to be used for creating and retrieving certs * Implement connector generate certificate request * Generate CSR for RSA and ECDSA * Uncomment connector interface method and throw exceptions for yet to be implemented methods * Add integration tests to verify phase

* Feature/request certificate cloud (#4) * migrates request certificate method for cloud * adds tests for request certificate for cloud

mr-tron · 2019-04-04T11:17:21Z

You can remove register. It`s deprecated function.

mr-tron · 2019-04-04T11:23:12Z

+        assertThat(zoneConfiguration.province()).isNull();
+        assertThat(zoneConfiguration.locality()).isNull();
+        assertThat(zoneConfiguration.policy()).isNotNull();
+        assertThat(zoneConfiguration.policy().subjectCNRegexes()).containsExactly(".*");


i don't know how and what type of regular expressions dialect do you use, but remember, that regexp should match full string. so for example regexp .*\.example\.com should doesn't match cn www.example.company

Hello I see, in this case, the test is validating that the API requires its correct from a stub external service https://github.com/opencredo/vcert-java-1/blob/68f1d07aaf4fc61e613361f68fb43b5932712cea/src/test/resources/mappings/cloud.certificatepolicies.di.json#L40

I dont big specialist in java. I didt know what java pattern.matches which match whole string. In golang you need to add ^ and $ to your regexp for matching whole string.

mr-tron · 2019-04-04T11:24:16Z

Also please move hardcoded tokens and urls in tests to environment variables.

* Retrieve certificate for cloud * Retrieve certificate for tpp

* migrates request certificate method for cloud * adds tests for request certificate for cloud * Feature/request certificate tpp (#5) * migrates request certificate method for tpp * adds test for request certificate for tpp

Not supported by cloud

Renew a cloud certificate

Bug/retrieve certificate

…tion Delete user registration

pegerto · 2019-04-05T14:16:22Z

You can remove register. It`s deprecated function.

Done

mr-tron · 2019-04-05T15:56:05Z

As I understand you just rewrite golang code to java. We are going to make some changes in the nearest future. May be you can just write better code from beginning and not copy our errors.

    certificate.Request has unused public attribute PublicKeyAlgorithm - should be removed (duplicated by KeyType)
    certificate.Request has public field CSR []byte what make misunderstoonding what can bein this field: pem or asn encoded csr. Should be replaced with private filed csr and few methods like SetCSR (may be with auto detect type), GetCSRasn1, GetCSRpem
    few methods accept empty interface as private key. should be replaced with crypto.Signer interface
    rewrite retrive function for cloud connector. should be getting certID by cn/thumbprint/pickupid -> getting certificate by certID via /v1/certificate/ {id}
    `func (cfg *Config) LoadFromFile() error` should be replaced with `func LoadConfigFromFile(path) (*Config, error)`
    SetBaseURL should be replaced with additional argument in NewConnector function //discuss

pegerto · 2019-04-05T16:44:20Z

Hello @M-Tron

I fully understand we discuss this in our proposal, it will be good to have a more fluent API and refactor sections on our code, unfortunately, we are time constrained, so we implement as match parity as possible for tracking.

We will try to implement part of the refactoring in this initial PR.

Fix zone configuration not setting keytype

pegerto · 2019-04-10T15:43:34Z

Also please move hardcoded tokens and urls in tests to environment variables.

we have externalized acceptance test so it can be run by an integration environment and document the variables in the README file

mr-tron · 2019-04-26T16:40:16Z

Can you also add example of library usages like https://github.com/Venafi/vcert/blob/master/example/main.go with

enrolling certificate
retrieving certificate
renew
checking certificate request with zone policies (I think CN will be enough)

pegerto · 2019-05-07T13:31:49Z

@mr-tron an Example class has been added this PR, The recommendation is to create a different project for examples, or submodule the project if more examples are required.

Include additional examples (fix key and examples) (#26)

pegerto and others added 7 commits March 21, 2019 11:25

Initial commit

aa1d8b6

Update README.md

d735e8e

Adds authorisation functionality for Cloud and Onprem (#1)

904cbfd

Adds authorization functionality for Cloud and Onprem

Read Zone Configuration, Wiremock

aa4ee53

* adds Read Zone Configuration functionality * adds Wiremock for testing

Merge branch 'current'

12e860e

Feature/registeruser (#1)

68f1d07

* Register an user venafi cloud * Add target to gitingnore

Search cloud certificates (#2)

a8f7133

* Search cloud certificates * Optimize imports

pmack24 added 2 commits April 3, 2019 18:23

Feature/generate cert (#6)

b092240

* Feature/request certificate cloud (#4) * migrates request certificate method for cloud * adds tests for request certificate for cloud

mr-tron reviewed Apr 4, 2019

View reviewed changes

pmack24 and others added 11 commits April 4, 2019 12:40

Feature/retrieve cert (#7)

a4a9301

* Retrieve certificate for cloud * Retrieve certificate for tpp

Feature/request certificate cloud (#8)

74f657f

* migrates request certificate method for cloud * adds tests for request certificate for cloud * Feature/request certificate tpp (#5) * migrates request certificate method for tpp * adds test for request certificate for tpp

Fix merge errors (#9)

c9f90e2

Certificate revoke for TPP (#10)

912e023

Not supported by cloud

Ping tpp and cloud (#12)

a699068

Import certificate for tpp (#13)

b606827

Feature/cloudrenew WIP (#11)

2af7d4f

Renew a cloud certificate

Retrive certificate request

fa15492

Retrive certificate from cloud

426fed3

Clean fetch AT

a794cae

Merge pull request #14 from opencredo/bug/retrive_certificate

cfd5fd4

Bug/retrieve certificate

pegerto changed the title ~~Bootstrap and Autorisation~~ Vcert-java initial implementation Apr 5, 2019

pegerto added 2 commits April 5, 2019 15:14

Delete user registration

fcb2d75

Merge pull request #15 from opencredo/feature/delete_feature_registra…

fb229d1

…tion Delete user registration

pegerto and others added 9 commits April 5, 2019 09:47

ZoneConfiguration Test (#16)

e90cb4b

At acceptance test for retrieve certificate (#17)

500442c

Fix zone configuration not setting keytype

VCertClient Implementation (#18)

cf18e6a

Register should not be tested as it have been removed (#19)

aa8ce61

Include example in readme (#20)

057c8ea

TPP certificate renew (#22)

bfe0fd0

Acceptance tests for cloud connector (#21)

9182c2e

Load configuration from file (#23)

d5aba64

Feature/acceptance tests tpp (#24)

bec1974

Include additional examples (#25)

50c91ff

Include additional examples (fix key and examples) (#26)

mr-tron merged commit a006b33 into Venafi:master May 28, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vcert-java initial implementation#2

Vcert-java initial implementation#2
mr-tron merged 32 commits intoVenafi:masterfrom
opencredo:master

pegerto commented Mar 28, 2019

Uh oh!

pegerto commented Mar 29, 2019

Uh oh!

mr-tron commented Apr 4, 2019

Uh oh!

mr-tron Apr 4, 2019

Uh oh!

pegerto Apr 5, 2019

Uh oh!

mr-tron Apr 6, 2019

Uh oh!

mr-tron commented Apr 4, 2019

Uh oh!

pegerto commented Apr 5, 2019

Uh oh!

mr-tron commented Apr 5, 2019

Uh oh!

pegerto commented Apr 5, 2019

Uh oh!

pegerto commented Apr 10, 2019

Uh oh!

mr-tron commented Apr 26, 2019

Uh oh!

pegerto commented May 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

pegerto commented Mar 28, 2019

Uh oh!

pegerto commented Mar 29, 2019

Uh oh!

mr-tron commented Apr 4, 2019

Uh oh!

mr-tron Apr 4, 2019

Choose a reason for hiding this comment

Uh oh!

pegerto Apr 5, 2019

Choose a reason for hiding this comment

Uh oh!

mr-tron Apr 6, 2019

Choose a reason for hiding this comment

Uh oh!

mr-tron commented Apr 4, 2019

Uh oh!

pegerto commented Apr 5, 2019

Uh oh!

mr-tron commented Apr 5, 2019

Uh oh!

pegerto commented Apr 5, 2019

Uh oh!

pegerto commented Apr 10, 2019

Uh oh!

mr-tron commented Apr 26, 2019

Uh oh!

pegerto commented May 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants